On Sun, Oct 19, 2008 at 01:29:50AM +0300, Felipe Balbi wrote: [...] > > > +#include "bq27x00.h" > > > + > > > +unsigned int cache_time = 60000; > > > > I think it should be static, no? > > > > > +module_param(cache_time, uint, 0644); > > > +MODULE_PARM_DESC(cache_time, "cache time in milliseconds"); > > > + > > > +enum power_supply_property bq27x00_props[] = { > > > > static? > > no, it's used by bq27200.c and bq27000.c I don't see where. The only user is bq27x00_powersupply_init(), which is in the same file (bq27x00.c). -- Anton Vorontsov email: cbouatmailru@xxxxxxxxx irc://irc.freenode.net/bd2 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html