On Sat, Oct 18, 2008 at 12:00:44AM +0300, Felipe Balbi wrote: > The previous driver for bq27x00 batteries was a real > ifdef mess. The following patches separate common code > and create separate drivers for bq27200 and bq27000. FYI (if you don't know already): Rodolfo Giometti already cleaned up bq27200 part of that driver and submitted it few months ago. http://lkml.org/lkml/2008/6/18/154 It will appear in the 2.6.28 kernel. For now it lives here: http://git.infradead.org/battery-2.6.git?a=commitdiff;h=b996ad0e9fb15ca4acc60bcd0380912117a45d13 So I'd be happy if you could just rework it to support bq27000 (w1) interface as well. > The code looks much cleaner, but we had to keep a global > static pointer to hold the i2c_client (bq27200) or the > w1 device (bq27000). Yeah, this is not great... > If anyone has a better solution, I'd like to hear since > keeping that global pointer doesn't look nice. Can you consider this idea http://kerneltrap.org/mailarchive/linux-kernel/2008/6/23/2198444 ? It shows only i2c part, but the idea should be clear: there should be w1 and i2c drivers, both would create bq27x00 platform devices, then the platform driver would not depend on any hw interface. Thanks, -- Anton Vorontsov email: cbouatmailru@xxxxxxxxx irc://irc.freenode.net/bd2 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
