On Thu, Oct 16, 2008 at 04:09:47PM -0700, ext David Brownell wrote: > On Wednesday 15 October 2008, Peter 'p2' De Schrijver wrote: > > --- /dev/null > > +++ b/arch/arm/mach-omap2/twl4030-generic-scripts.h > > @@ -0,0 +1,8 @@ > > +#ifndef __TWL4030_GENERIC_SCRIPTS_H > > +#define __TWL4030_GENERIC_SCRIPTS_H > > + > > +#include <linux/i2c/twl4030.h> > > + > > +extern struct twl4030_power_data generic3430_t2scripts_data; > > + > > +#endif > > I'd still put this decl into arch/arm/mach-omap2/pm.h, which > is already a bit of a grab-bag of PM hooks. As you noted, > having a header for a single declaration isn't the Best Way. In retrospect I don't think that's such a good idea either. pm.h contains prototypes related to OMAP2/3 powermanagement. Even though twl4030 plays some role in powermanagement, it's more at the system level then at the OMAP chip level. Ie. from an OMAP point of view nothing has to be switched off. But from a system point of view, it does save some power to switch things off. So I don't feel it belongs there. Cheers, Peter. -- goa is a state of mind -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
