Re: [patch 2.6.27-omap-git+ 6/5] twl4030 MMC card detction

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 14 October 2008, David Brownell wrote:
> Replace stubbed-out card-detect support for twl4030 GPIOs with
> a simpler platform_data mechanism.  As before, no current users.
> Sanity tested by enabling this on Beagle; it booted OK with
> root on MMC.
> 
> Signed-off-by: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/gpio/twl4030-gpio.c |   52 +++++++++---------------------------------
>  include/linux/i2c/twl4030.h |    3 ++
>  2 files changed, 15 insertions(+), 40 deletions(-)

By the way, a minor comment:  I noticed that there are also
settings in the PM_RECEIVER "dc-to-dc_GLOBAL_CFG" register
to change the card detect signal from active high (which is
the default) to active low.

This patch doesn't support such signal polarity options,
but it'd seem likely to me that some boards will need them.
Someday later than today.  :)

This email is just to note this issue ... fixing it should
be trivial, there are several more bits available in that
byte which could be used to configure polarity.

- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux