On Tue, Oct 14, 2008 at 10:19:52AM -0700, David Brownell wrote: > On Tuesday 14 October 2008, Felipe Balbi wrote: > > On Tue, Oct 14, 2008 at 08:53:28AM -0700, David Brownell wrote: > > > On Tuesday 14 October 2008, Felipe Balbi wrote: > > > > This driver should be sitting together with the other > > > > led drivers. > > > > > > ... iff it actually uses the LED framework. Which it > > > doesn't, yet, even for simple operations. > > > > Should I change the order of the patches ? The patch going to Richard is > > only the final version of it, so there wouldn't be any difference for > > him I'd say. > > The rule of thumb is to preserve bisectability. That may be less > important inside the OMAP tree. The sequencing is fine, but it'd > be less confusing to patch-at-a-time review to at least see the > comment that a *later* patch makes it use the LED framework. makes sense, I'll put a comment to patch 2. -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
