On Tue, Oct 14, 2008 at 08:55:21AM -0700, David Brownell wrote: > On Tuesday 14 October 2008, Felipe Balbi wrote: > > @@ -23,7 +24,9 @@ > > #include <linux/module.h> > > #include <linux/init.h> > > #include <linux/i2c.h> > > +#include <linux/leds.h> > > #include <linux/mutex.h> > > +#include <linux/workqueue.h> > > > > #define LP5521_DRIVER_NAME "lp5521" > > > > Ah, *here* it converts to use the LED framework. The patch > comment should probably focus on that ... "separate leds" is > just an artifact of that conversion, as I interpret things. Sure, I'll update and resend tomorrow. The ambient light sensor, I'll drop from now and leave it pending until we have a good answer for where it should go. -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html