Hi Doyu-san, Thank you for your comments. > By the way, would it be possible to replace this "sync.c" with normal > in-kernel APIs like "mutex_lock()" and "wait_event()" families? > > There's no point to have home brewed synchronization APIs, but it may > lose the readability of the code. If you need to add debug feature to > kernel synchronization mechanism, it should be done in generic APIs, > not in the driver specific code. I agree with you that we would lose the readability and also any changes to the sync module functionality will have an impact on the current Bridge design and might require considerable amount of rework. I wouldn't be comfortable removing the sync module completely for above mentioned reasons, but we can look at analyzing and making the changes in a phased manner. Thank you, Best regards, Hari > -----Original Message----- > From: Hiroshi DOYU [mailto:Hiroshi.DOYU@xxxxxxxxx] > Sent: Wednesday, October 08, 2008 11:46 PM > To: Ramirez Luna, Omar; Kanigeri, Hari > Cc: Pandita, Vikram; linux-omap@xxxxxxxxxxxxxxx > Subject: Re: [PATCH][omapzoom] BRIDGE Add preemption support to > unprotected functions > > Hi Omar and Hari, > > From: "ext Ramirez Luna, Omar" <x00omar@xxxxxx> > Subject: [PATCH][omapzoom] BRIDGE Add preemption support to unprotected > functions > Date: Wed, 8 Oct 2008 17:07:15 -0500 > > > From: Hari Kanigeri <h-kanigeri2@xxxxxx> > > Date: Fri, 3 Oct 2008 12:20:45 -0500 > > Subject: [PATCH] BRIDGE Add preemption support to unprotected functions > > > > This patch protects the critical sections in bridge > > driver that otherwise might end in unexpected behavior. > > Nice catch. > > By the way, would it be possible to replace this "sync.c" with normal > in-kernel APIs like "mutex_lock()" and "wait_event()" families? > > There's no point to have home brewed synchronization APIs, but it may > lose the readability of the code. If you need to add debug feature to > kernel synchronization mechanism, it should be done in generic APIs, > not in the driver specific code. > > Hiroshi DOYU > > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
