Hi David,
>
> Your set of patches seems to have discarded support for quite
> a few platforms. I don't quite know the details of what these
> PM scripts are doing ... could they be misbehaving on Beagle,
> so that they explain why "reboot" on RC8 fails?
>
>
It might. At least the warmreset script might cause problems on Beagle.
I'm not familiar enough with beagle to know for sure.
> > +static int __init twl4030_power_probe(struct platform_device *pdev)
>
> Pretty much everything here is "init" code, which is fine;
> I like seeing smaller runtime images. But:
>
>
> >
> > @@ -340,4 +271,17 @@ static int __init twl4030_power_init(void)
> >
> > }
> >
> > +static struct platform_driver twl4030_power = {
> > + .probe = twl4030_power_probe,
> > + .driver = {
> > + .name = "twl4030_power",
> > + .owner = THIS_MODULE,
> > + },
> > +};
> > +
> > +static int __init twl4030_power_init(void)
> > +{
> > + return platform_driver_register(&twl4030_power);
>
> ... in that case, why not platform_driver_probe(), so there's
> not even a whiff of a notion that this driver remain init is
> done?
>
That's correct. The 'driver' basically loads the scripts in the twl4030 and
that's it. The hw will then execute the scripts when necessary.
> And I can't help but wonder why this isn't just part of
> the twl4030-core code, without even a platform device/driver.
If you think all this script loading stuff can go into twl4030-core, I
can make a patch to move it there.
>
> I didn't move it to drivers/mfd because it seemed almost all
> SDP-specific. But to the extent that it's something generic
> and "part of the core", maybe that's where it should be.
> Not necessarily part of the same file.
>
It's not SDP specific, but it is OMAP specific I think. At least I can't
see use cases outside OMAP2/3.
Cheers,
Peter.
--
goa is a state of mind
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
