RE: [PATCH] MUSB: Fixes endpoint allocation logic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 7, 2008 at 2:36 AM, Ajay Kumar Gupta <ajay.gupta@xxxxxx> wrote:
> musb->periodic[] flag was getting set for an endpoint even when only rx
> or tx is used.This patch adds two field musb->in[16] and musb->out[16]
> in place of musb->periodic[32] which will enable endpoint allocation
> flag setting on rx/tx basis of an endpoint.

> To apply this I had to make some changes to an older patch, since it
> used ->periodic:
> http://marc.info/?l=linux-omap&m=122284678326859&w=2

> It seems to be working fine.  But, is there a way to get the latest
> versions of the pending MUSB patches?
> - Nathan

There are some changes required in my older patch 
http://marc.info/?l=linux-omap&m=122284678326859&w=2

I will submit a fresh patch again once it gets reviewd. Meanwhile I am
copying the changes which can be applied manually.

1) within musb_urb_dequeue()

-		if (usb_pipeisoc(type))
-			musb->periodic[qh->hw_ep->epnum] = NULL;
+		if (usb_pipeisoc(type) && usb_pipein(type))
+			musb->in[qh->hw_ep->epnum] = NULL;
+		else if (usb_pipeisoc(type) && usb_pipeout(type))
+			musb->out[qh->hw_ep->epnum] = NULL;

2) within musb_h_disable()

-		for (i = 0; i < musb->nr_endpoints; i++) {
-			if (musb->periodic[i] == qh)
+		for (i = 1; i < musb->nr_endpoints; i++) {
+			if ((musb->in[i] == qh) || (musb->out[i] == qh))

Regards,
Ajay

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux