On Thu, 11 Sep 2008 14:35:04 +0300
Felipe Balbi <felipe.balbi@xxxxxxxxx> wrote:
>
> Maybe Pierre should be watching this patch as well. I'm putting him in
> the loop.
>
Thanks ;)
When/if you want to submit this, put the core stuff in a separate patch.
> > @@ -111,11 +112,12 @@ struct mmc_host {
> > unsigned long caps; /* Host capabilities */
> >
> > #define MMC_CAP_4_BIT_DATA (1 << 0) /* Can the host do 4 bit transfers */
> > -#define MMC_CAP_MMC_HIGHSPEED (1 << 1) /* Can do MMC high-speed timing */
> > -#define MMC_CAP_SD_HIGHSPEED (1 << 2) /* Can do SD high-speed timing */
> > -#define MMC_CAP_SDIO_IRQ (1 << 3) /* Can signal pending SDIO IRQs */
> > -#define MMC_CAP_SPI (1 << 4) /* Talks only SPI protocols */
> > -#define MMC_CAP_NEEDS_POLL (1 << 5) /* Needs polling for card-detection */
> > +#define MMC_CAP_8_BIT_DATA (1 << 1) /* Can the host do 8 bit transfers */
> > +#define MMC_CAP_MMC_HIGHSPEED (1 << 2) /* Can do MMC high-speed timing */
> > +#define MMC_CAP_SD_HIGHSPEED (1 << 3) /* Can do SD high-speed timing */
> > +#define MMC_CAP_SDIO_IRQ (1 << 4) /* Can signal pending SDIO IRQs */
> > +#define MMC_CAP_SPI (1 << 5) /* Talks only SPI protocols */
> > +#define MMC_CAP_NEEDS_POLL (1 << 6) /* Needs polling for card-detection */
>
> This would require changes to all other mmc host drivers, right ?
> How about:
>
> +#define MMC_CAP_8_BIT_DATA (1 << 6) /* Can the host do 8 bit transfers */
>
This is not an exposed ABI so this kind of fiddling it not a problem.
Rgds
--
-- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org
rdesktop, core developer http://www.rdesktop.org
WARNING: This correspondence is being monitored by the
Swedish government. Make sure your server uses encryption
for SMTP traffic and consider using PGP for end-to-end
encryption.
Attachment:
signature.asc
Description: PGP signature
