On Fri, Sep 19, 2008 at 05:41:44PM -0700, David Brownell wrote:
> On Friday 19 September 2008, Felipe Balbi wrote:
> > static int omap_wdt_open(struct inode *inode, struct file *file)
> > {
> > - struct omap_wdt_dev *wdev;
> > - void __iomem *base;
> > - wdev = platform_get_drvdata(omap_wdt_dev);
> > - base = wdev->base;
> > + struct omap_wdt_dev *wdev = platform_get_drvdata(omap_wdt_dev);
> > + void __iomem *base = wdev->base;
> > +
>
> Oh, I see where "omap_wdt_dev" (global) gets used. The normal
> way to do stuff like that is using void* pointers placed in the
> inode and file structures for exactly that purpose.
You don't have an inode or a file structure until open() is called -
at which point it _is_ placed in file->private_data. So this driver
is doing the right thing.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
