>From: ext Tony Lindgren [mailto:tony@xxxxxxxxxxx] >Sent: 11 September, 2008 03:29 > >I've redone the id.c, the old one was getting messy for omap2. >Maybe try my patch I posted on Tuesday and see how it works for you? Hmm did not notice this patch, just made a quick fix for this as I was seeing some problems with CPU type detection. I need to check this out when I have more time for this. > >Also one comment below. >> #define OMAP3430_REV_ES1_0 0x34300000 >> #define OMAP3430_REV_ES2_0 0x34301000 >> #define OMAP3430_REV_ES2_1 0x34302000 >> -#define OMAP3430_REV_ES2_2 0x34303000 >> +#define OMAP3430_REV_ES3_0 0x34303000 >> >> /* >> * omap_chip bits > >Are you sure ES3.0 gives a three for revision? I believe 2.2 >had 3, or is the revision register broken again? I have tested this piece of code with ES2.1 and ES3.0 and it gives correct results, so I am certain 3.0 gives a 3 for rev. Regarding 2.2 I am not so sure, I think such chip revision does not exist at all. There was also something weird with the earlier code as it increased revision by 1, thus giving wrong results for any revision... and causing is_sil_rev_* macros to give incorrect results. -Tero -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
