Hi, Although this TI bridge patches are not integrated and a bit independent S/W component, it would be nice to get some comments just on this bridge header file location from kernel maintainer's perspective. "arch/arm/plat-omap/include/mach/bridge" or "arch/arm/plat-omap/include/bridge"? Hiroshi DOYU From: Hiroshi DOYU <Hiroshi.DOYU@xxxxxxxxx> Subject: Re: [PATCH 2/3][OMAP 3/4]table end for wcd command definitions Date: Fri, 29 Aug 2008 08:03:13 +0300 (EEST) > Hi Omar, > > I just noticed that the bridge specific header files are located > under "linux/arch/arm/plat-omap/include/mach/bridge/", but it may be > better to have them under "arch/arm/plat-omap/include/bridge/" because > those header files are not related to the omap archtecture so much and > mostly used for bridge specific purpose, although omap is the only > platform to have bridge with dsp;) For me, it would make more sense > logically, and also practically grepp'ing would work more nicely > without any fancy tools like specifiying the directories to search. > > Any comments? > > Hiroshi DOYU > > From: "ext Ramirez Luna, Omar" <x00omar@xxxxxx> > Subject: [PATCH 2/3][OMAP 3/4]table end for wcd command definitions > Date: Thu, 28 Aug 2008 20:30:44 -0500 > > > Added the table end 'CMD_BASE_END_OFFSET' define in wcdioctl.h > > > > Signed-off-by: Omar Ramirez Luna <x00omar@xxxxxx> > > --- > > > > Index: omapkernel/arch/arm/plat-omap/include/mach/bridge/wcdioctl.h > > =================================================================== > > --- omapkernel.orig/arch/arm/plat-omap/include/mach/bridge/wcdioctl.h 2008-08-22 19:03:10.000000000 -0500 > > +++ omapkernel/arch/arm/plat-omap/include/mach/bridge/wcdioctl.h 2008-08-22 19:20:05.000000000 -0500 > > @@ -515,4 +515,5 @@ > > #define CMD_CMM_GETINFO_OFFSET (CMD_CMM_BASE_OFFSET + 3) > > #define CMD_CMM_END_OFFSET CMD_CMM_GETINFO_OFFSET > > > > +#define CMD_BASE_END_OFFSET CMD_CMM_END_OFFSET > > #endif /* WCDIOCTL_ */ > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > > the body of a message to majordomo@xxxxxxxxxxxxxxx > > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
