On Sun, Sep 7, 2008 at 1:04 PM, David Brownell <david-b@xxxxxxxxxxx> wrote: > On Thursday 04 September 2008, Gadiyar, Anand wrote: >> From: Anand Gadiyar <gadiyar@xxxxxx> >> >> The Index register needs to be zero to access CONFIGDATA. >> musb_ep_select()will not set the MUSB_INDEX register unless INDEXED >> mode addressing is used. This change will set the register correctly >> in INDEXED as well as FLAT mode. >> >> Signed-off-by: Anand Gadiyar <gadiyar@xxxxxx> >> CC: Ajay Kumar Gupta <ajay.gupta@xxxxxx> > > ACK. I *know* it was originally written that way. I think > the change was one of the Blackfin patches ... I hope this > isn't one of those cases where the Blackfin version of this > core acts differently. (Like clearing that DMA IRQ status...) > For Blackfin, the register MUSB_CONFIGDATA is not exported out to software. So in the musb driver, Blackfin code can not access the MUSB_CONFIGDATA. The configuration is fixed in the software. -Bryan > >> --- >> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c >> index b398776..6c4da2f 100644 >> --- a/drivers/usb/musb/musb_core.c >> +++ b/drivers/usb/musb/musb_core.c >> @@ -1334,7 +1334,7 @@ static int __init musb_core_init(u16 musb_type, struct musb *musb) >> int i; >> >> /* log core options (read using indexed model) */ >> - musb_ep_select(mbase, 0); >> + musb_writeb(mbase, MUSB_INDEX, 0); >> reg = musb_readb(mbase, 0x10 + MUSB_CONFIGDATA); >> >> strcpy(aInfo, (reg & MUSB_CONFIGDATA_UTMIDW) ? "UTMI-16" : "UTMI-8");-- >> To unsubscribe from this list: send the line "unsubscribe linux-usb" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > > > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
