On Fri, Sep 5, 2008 at 10:52 AM, Tony Lindgren <tony@xxxxxxxxxxx> wrote: > * Steve Sakoman <sakoman@xxxxxxxxx> [080905 10:24]: >> > Hmm, is the musb broken now? >> >> It is on Overo if I base my patches against current top of tree >> (a376251519ced5831ed07ed234430725230ed93a) >> >> Doesn't crash, just quietly doesn't work. I hear from Beagle folk >> that musb doesn't work there either. I have it configured as a host >> port, and IIRC so do the Beagle folks >> >> If I base my patches against the state of the tree just prior to the >> move to rc5 (81c893795c2e1fbe0bf5f638ed6ae1e500b80a2d), musb works as >> well as it ever has. > > Well with -rc5 we switched to the drivers/usb/musb code from mainline > kernel. Maybe try to diff musb code with: > > $ git-diff 81c893795c2e1fbe0bf5f638ed6ae1e500b80a2d.. drivers/usb/musb > > And see if there are any clues? I did that and found that there are very few changes of substance, mostly formatting and comments. In fact there were only a few lines that looked promising at all. Mans Rullgard has verified that restoring these few lines fixes the musb issue on beagle (using musb in gadget mode) and I have verified that it fixes the issue on Overo (which uses musb in host mode). Mans has a patch in his git: http://git.mansr.com/?p=linux-omap;a=commitdiff;h=1e5bc41773bb981b3a89bd762becf98c72be5e4c Neither of us understand musb details enough to propose this as *the* fix, but it seems likely to be the issue. Steve -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
