On Thursday 04 September 2008, Madhusudhan Chikkature wrote: > > OK, this one may need cleanup ... but I don't disagree that it > > should go upstream. > > I had fixed several comments provided by Pierre and Russell > before Tony merged this patch. But then we have further added > several fixes on top of the driver. Do you have any specific > comments when you mean cleanup My main concerns relate to board-specific setup, which might not end up impacting the driver code as much as the code in arch/arm/mach-omap2/hsmmc.c (and its callers). Basically, if you look at the hsmmc.c file it's got a LOT of board-specific stuff hard-wired. The way it *should* work is the board-XYZ.c file passes that into setup code ... and that info can include things like "are all 8 data lines available?", as well as card detect triggering and writeprotect switch access. There might be other issues ... but it was rather easy to notice those problems when for example the HSMMC on a Beagle comes up with truncated functionality. - Dave -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
