Hi Dave, >OK, this one may need cleanup ... but I don't disagree that it >should go upstream. I had fixed several comments provided by Pierre and Russell before Tony merged this patch. But then we have further added several fixes on top of the driver. Do you have any specific comments when you mean cleanup? Regards, Madhu ----- Original Message ----- From: "David Brownell" <david-b@xxxxxxxxxxx> To: "Felipe Balbi" <me@xxxxxxxxxxxxxxx> Cc: <linux-omap@xxxxxxxxxxxxxxx>; "Felipe Balbi" <felipe.balbi@xxxxxxxxx> Sent: Monday, September 01, 2008 2:36 AM Subject: Re: [PATCH 21/33] add OMAP HighSpeed mmc controller driver On Saturday 30 August 2008, Felipe Balbi wrote: > From: Felipe Balbi <felipe.balbi@xxxxxxxxx> > > Signed-off-by: Felipe Balbi <felipe.balbi@xxxxxxxxx> > --- > drivers/mmc/host/Kconfig | 13 +- > drivers/mmc/host/Makefile | 1 + > drivers/mmc/host/omap_hsmmc.c | 1069 +++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 1082 insertions(+), 1 deletions(-) > create mode 100644 drivers/mmc/host/omap_hsmmc.c OK, this one may need cleanup ... but I don't disagree that it should go upstream. Now the process for getting it there involves posting to LKML and probably CCing the MMC maintainer... One reason I'd like to see this particular driver upstream is so that folk using www.beagleboard.org hardware can stand a real chance of using mainline kernels for development. That's a small set of drivers, so that's a very achievable goal. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html