On Tue, Sep 2, 2008 at 8:15 AM, David Brownell <david-b@xxxxxxxxxxx> wrote: > On Monday 01 September 2008, sakoman@xxxxxxxxx wrote: >> + .name = "jffs2", > > Suggest "rootfs" instead ... have you looked at UBI/UBIFS instead? > I plan to use it on my Beagle... > > >> + gpio_direction_output(W2W_NRESET, 0); >> + udelay(10); >> + gpio_direction_output(W2W_NRESET, 1); > > These should be gpio_set_value(...) ... you already set the direction. > Ditto for BT_NRESET. And a suggestion: prefix those symbols with > something like OVERO_GPIO_ ... OVERO_ in case these move to public > headers (board-overo.h), GPIO_ since that's what they are. > > >> +++ b/drivers/video/omap/lcd_overo.c > > Strictly speaking this should be in a separate patch. Excellent suggestions! I will include in my resubmission. Steve -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
