Re: [patch 2.6.27-rc3-omap1] omap3 beagle: nand (mostly) cleanups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Friday 29 August 2008, Woodruff, Richard wrote:
> > Clean up the Beagle NAND config a bit:  use SZ_128K instead of
> > an arithmetic expression for the NAND block size.  Set the
> > NAND_BUSWIDTH_16 flag.  Make its init routine static.
> 
> 
> Actually, this was talked about before a bit and the SZ_xyz flags were left out.
> 
> The point of telling the geometry in the addition was to be explicit
> about the number of sectors being used. 

So #define NAND_BLOCK_SIZE SZ_128K and use that symbol instead?

Frankly N*(64 * 2048) isn't very meaningful.  The comment at the
top already says everything is in units of blocks, but one is  left
to guess that "block" is "(64 * 2048)"...


--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux