> > Why are there any proc files in this driver? Drivers should not add > > proc files. Hm, should have reviewed this code a bit better, sorry... With that much code, it's just a question of _how much_ any review ends up missing. > We needed a quick way to export the testmodes to userland. And it's been > used for that. > > > Can you please just remove them all? > > Yeah, I'm moving them to debugfs. I can remove everything and later add > only the debugfs if you like. And would you believe this is the *trimmed down* proc file? Sigh. I removed almost all of that support a couple years ago, preparing to remove it entirely ... the problem spot was the *write* paths. Taking any of them out seemed to have a significant negative impact on ability to get this code working on new hardware. Glad to see Felipe is finishing that. - Dave -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
