Re: [PATCH] usb: musb: get rid of MUSB_LOGLEVEL and use parameter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Aug 10, 2008 at 10:53:19AM -0700, Greg KH wrote:
> On Sun, Aug 10, 2008 at 03:20:46PM +0300, Felipe Balbi wrote:
> > From: Felipe Balbi <felipe.balbi@xxxxxxxxx>
> > 
> > We can change debugging level on the fly via
> > /sys/module/musb_hdrc/parameters/debug, there's no
> > need for an extra command in the proc entry.
> 
> Why are there any proc files in this driver?  Drivers should not add
> proc files.  Hm, should have reviewed this code a bit better, sorry...

We needed a quick way to export the testmodes to userland. And it's been
used for that.

> Can you please just remove them all?

Yeah, I'm moving them to debugfs. I can remove everything and later add
only the debugfs if you like.

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux