RE: [PATCH 0/4] OMAP: MENELAUS: Improvements on menelaus

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 2008/7/29 Felipe Balbi <me@xxxxxxxxxxxxxxx>:
>> On Tue, Jul 29, 2008 at 02:07:51PM -0500, Woodruff, Richard wrote:
>>> > How about renaming it to twl92230c before submitting upstream?  As far
>>> > as I can tell the name menelaus appears only in linux and makes it
>>> > hard to associate with the real hardware.  Does someone know why was
>>> > it renamed that way?
>>
>>> A number does seem more understandable.  Though some of these chips live under a few different numbers.
>>
>> it does seem more understandable, but now that it has been used for so
>> long I guess it would be nasty to change right now. Almost every one
>> here knows that menelaus is the companion chip for omap2 hw. Personally,
>> I never recall the correct number designation for menelaus.
>
> Well, menelaus is a friendly name now that I know what it is but it
> was difficult to find its datasheet without knowing the public name
> used by the manufacturer, it seemed like a nokia's own chip. Also iirc
> if you open the device you will only see the TWLxxx name on the chip.
>
> I see TWLxxx is now mentioned in the Kconfig so I won't insist.
>
> Cheers

I think it'll be hard for a newbie to figure out what this menelaus is. Google
won't help either, (unless one really thinks there is a connection between
Linux and Greek Mythology ;) ).

I second renaming the file to TWL92230. Mentioning this in Kconfig is simply
not enough.

My 375 million ZWD,
Anand
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux