On Fri, Jun 27, 2008 at 05:27:48PM +0530, ext Rajendra Nayak wrote: > Hi Peter, > > I have the CORE off working on top of Jouni's latest patch set posted on l-o. > > 2 issues which I saw due to which CORE OFF was broken > 1) Control module registers were redefined with the same name in control.h while my patches > defined them in cpuidle34xx.h. In control.h they were just offsets and in cpuidle34xx.h they were defined as physical address. > While saving the control module context, the offset was getting passed to omap_readl resulting in a crash. > 2) GPIO clocks disable was moved into SRAM code in Jouni's patch, which would not get executed in OFF path. > Thanks. I'm testing them now. 013-TIPATCH-fix-core-off.patch patches include/asm/arch/control.h which doesn't exist on a non-configured kernel. It's better to have the patch modify include/asm-arm/arch-omap/control.h. Cheers, Peter. -- goa is a state of mind -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
