On Mon, Jun 23, 2008 at 03:51:09PM -0600, Miguel Angel Aguilar Ulloa wrote: > Add twl4030 keypad driver support to OMAP3 EVM Generally all your patches look really good but the subject should be something more self-explanatory. For this first is ok, but second and third should be something like: OMAP3: EVM: KEYPAD: Fix Kconfig dependency OMAP3: EVM: KEYPAD: Add twl4030 keypad to defconfig or something similar ;-) -- Best Regards, Felipe Balbi me@xxxxxxxxxxxxxxx http://blog.felipebalbi.com -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html