Hi Felipe, Thanks for the comments. I will fix it and resend the patch. Best regards, Madhu ----- Original Message ----- From: "Felipe Balbi" <me@xxxxxxxxxxxxxxx> To: <x0070977@xxxxxxxxxxxxxxxxxx> Cc: <linux-omap@xxxxxxxxxxxxxxx> Sent: Monday, June 23, 2008 2:21 PM Subject: Re: [RFC/PATCH 2/2] Triton Battery charger interface driver for OMAP3430 > > > On Fri, 20 Jun 2008 17:36:00 +0530 (IST), x0070977@xxxxxxxxxxxxxxxxxx > wrote: > >> +#ifdef CONFIG_TWL4030_BCI_BATTERY >> +extern int twl4030charger_usb_en(int enable); >> +#else >> +static inline int twl4030charger_usb_en(int enable) { return 0; } >> +#endif > > this should be in include/linux/i2c/twl4030.h > you should also change it for when bci is built as a > dynamically linked module. Okay. Good point. > > -- > Best Regards, > > Felipe Balbi > http://felipebalbi.com > me@xxxxxxxxxxxxxxx > > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html