Re: [PATCH 1/2] usb: musb: MUSB_OTG should depend on PM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Felipe Balbi <felipe.balbi@xxxxxxxxx> [080611 14:09]:
> Current musb Kconfig causes cyclic depency on x86
> arch. The best fix is to depend on PM in order to
> build on OTG mode.
> 
> Anyone interested in reproducing the error in your
> linux-omap trees, just make ARCH=x86 menuconfig

I guess this is now obsolete with Dave's HAS_CLK patch?

Tony

> Signed-off-by: Felipe Balbi <felipe.balbi@xxxxxxxxx>
> ---
>  drivers/usb/musb/Kconfig |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig
> index a485a86..acbbd5f 100644
> --- a/drivers/usb/musb/Kconfig
> +++ b/drivers/usb/musb/Kconfig
> @@ -88,10 +88,9 @@ config USB_MUSB_PERIPHERAL
>  	  (With a "Mini-AB" connector, you should enable USB OTG.)
>  
>  config USB_MUSB_OTG
> -	depends on USB && USB_GADGET && EXPERIMENTAL
> +	depends on USB && USB_GADGET && PM && EXPERIMENTAL
>  	bool "Both host and peripheral:  USB OTG (On The Go) Device"
>  	select USB_GADGET_MUSB_HDRC
> -	select USB_OTG
>  	select PM
>  	help
>  	   The most notable feature of USB OTG is support for a
> -- 
> 1.5.6.rc1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux