Hi Hari, On 6/17/08, Kanigeri, Hari <h-kanigeri2@xxxxxx> wrote: > Hi Trilok, > > > This code is sitting on pile of un-necessary wrappers, doesn't use > > common frameworks which were already written once for nokia > > dspgateway, > > --- This is addressed in the email sent to the mailing list. > > > I am sure it will not pass checkpatch and sparse screening > > tests even. > > --- The checkpatch (version 18) is ran on the patch file that is sent to > the mailing list, and we observed only 65 errors (most of them are false > errors reported by checkpatch), and there are around 365 warnings > (mostly complaints on typedefs) > > > >, doesn't use > > common frameworks which were already written once for nokia > > dspgateway, > > ---- It is agreed with Doyu-san that we will consider this as a long > term plan. > Setting up a GIT tree for dspbridge driver, should not be on long term plan, as long term plan should be to get dspbridge merged on to OMAP GIT itself. In this case separate GIT tree, should serve as staging tree and playground for cleanups so that others (specifically outside TI guys) can watch your commits/comment and help you guys on cleanups. It is really tough to track and review your changes as you are putting very big patches and we are unable to keep sync with your changes in incremental fashion. For most of the open source guys, setting up GIT tree is sometime first step in-order to make changes visible to others in better way :) -- ---Trilok Soni http://triloksoni.wordpress.com -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
