Hello Tero,
A few minor comments based on a quick look.
In terms of the OMAP3 code, is that for retention-idle only, or does it
work with off-idle also?
On Tue, 10 Jun 2008, Tero Kristo wrote:
> +const u32 omap2_uart_wk_bit[OMAP_MAX_NR_PORTS] = {
> + OMAP24XX_ST_UART1, OMAP24XX_ST_UART2, OMAP24XX_ST_UART3
> +};
Looks like that can be static.
> +/* UART padconfig registers, these may differ if non-default padconfig
> + is used */
> +#define CONTROL_PADCONF_UART1_RX 0x48002182
> +#define CONTROL_PADCONF_UART2_RX 0x4800217A
> +#define CONTROL_PADCONF_UART3_RX 0x4800219E
> +#define PADCONF_WAKEUP_ST 0x8000
Please use omap_ctrl_read{b,w,l}() rather than omap_read{b,w,l}() for SCM
addresses.
Also, the above are register addresses + 2. Is it possible to use the
actual register addresses (ideally they should be defined in
include/asm-arm/arch-omap/control.h), do long reads, and simply shift the
register contents for the serial ports that need it?
- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
