Re: [PATCH 2/2] ARM: OMAP: Add OMAP34xx pin muxing into I2C bus registration helper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon,  9 Jun 2008 17:46:41 +0300
Jarkko Nikula <jarkko.nikula@xxxxxxxxx> wrote:

> Signed-off-by: Jarkko Nikula <jarkko.nikula@xxxxxxxxx>
> ---
>  arch/arm/plat-omap/i2c.c |   51 +++++++++++++++++++++++++++
> +----------------- 1 files changed, 32 insertions(+), 19 deletions(-)
> 
> -static void __init omap_i2c_mux_pins(int bus_id)
> +static const int omap1_pins[][2] = {
> +	{ I2C_SCL, I2C_SDA },
> +};
> +static const int omap24xx_pins[][2] = {
> +	{ M19_24XX_I2C1_SCL, L15_24XX_I2C1_SDA },
> +	{ J15_24XX_I2C2_SCL, H19_24XX_I2C2_SDA },
> +};
> +static const int omap34xx_pins[][2] = {
> +	{ K21_34XX_I2C1_SCL, J21_34XX_I2C1_SDA},
> +	{ AF15_34XX_I2C2_SCL, AE15_34XX_I2C2_SDA},
> +	{ AF14_34XX_I2C3_SCL, AG14_34XX_I2C3_SDA},
> +	{ AD26_34XX_I2C4_SCL, AE26_34XX_I2C4_SDA},
> +};
> +
NAK to myself. Avoiding few #ifdefs is not an excuse for spending some
bytes here and also it doesn't look good to add muxing support for bus
4 where the module itself doesn't support it (yet).

Lazy me :-)

Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux