On Sat, Jun 7, 2008 at 3:23 PM, Chandra shekhar <x0044955@xxxxxx> wrote: > >> -----Original Message----- >> From: linux-omap-owner@xxxxxxxxxxxxxxx >> [mailto:linux-omap-owner@xxxxxxxxxxxxxxx] On Behalf Of Koen Kooi >> Sent: Friday, June 06, 2008 8:59 PM >> To: Eduardo Valentin >> Cc: Felipe Balbi; arun c; linux-omap@xxxxxxxxxxxxxxx >> Subject: Re: [PATCH] Fix for the i2c initialiation error on 2430sdp >> >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA1 >> >> >> Op 6 jun 2008, om 16:57 heeft Eduardo Valentin het volgende >> geschreven: >> >> > Hi, >> > >> > On Fri, Jun 6, 2008 at 10:46 AM, Felipe Balbi <me@xxxxxxxxxxxxxxx> >> > wrote: >> >> >> >> >> >> On Fri, 6 Jun 2008 18:42:56 +0530, "arun c" >> >> <arunedarath@xxxxxxxxxxxxxxxxxxxx> wrote: >> >>> static int __init omap2430_i2c_init(void) { >> >>> - omap_register_i2c_bus(1, 400, NULL, 0); >> >>> omap_register_i2c_bus(2, 2600, NULL, 0); >> >>> + omap_register_i2c_bus(1, 400, NULL, 0); >> >> >> >> maybe there's a hw restriction that you must initiliaze hs >> bus first? > > > There isn't any hardware restriction while registering the busses. Although we can put a comment As Chandra shekhar verified there is no hardware restriction, I will put a comment and resend the patch. > As to why we are registering the bus 2 first. > Also itWouldn't matter to 3430 as TWL4030 is on bus 1. > > >> > >> > If that is the reason, it'd be good to add some comment >> here to avoid >> > people re-ordering it in the future. >> >> I wonder if this applies to omap3 as well. >> >> regards, >> >> Koen >> -----BEGIN PGP SIGNATURE----- >> Version: GnuPG v1.4.5 (Darwin) >> >> > > > Regards > Chandra Shekhar > Regards, Arun C -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
