Paul Walmsley wrote:
Hi Kevin, On Tue, 20 May 2008, Kevin Hilman wrote: > The locking in the get_rate() hook is unnecessary, and causes problems > when used with the -rt patch, since it may be called recursively. > > Signed-off-by: Kevin Hilman <khilman@xxxxxxxxxx> Acked-by: Paul Walmsley <paul@xxxxxxxxx> BTW, looks like we could probably get rid of some of the other spinlocking in plat-omap/clock.c also -- clk_get_usecount() ?
I agree, most of the locking in there seems unnecessary, but this was the only one that could be removed without looking closer at at all the platform specific clock code.
Basically, I think there minimal (maybe no) locking in the generic layer, and the locking should be done if necessary in the platform specific parts.
Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
