Hi Tony and Trilok, I was out of office this last week due to some trainings and brazilian holidays, so that's why this message is delayed. I'm sending a version of this series including your patch and your comments. Please review them as usual. I think that Chandra can still put his work on top of this as the change is not that big. On Tue, May 20, 2008 at 7:44 PM, Tony Lindgren <tony@xxxxxxxxxxx> wrote: > Hi, > > Some comments below. <snip> > > You need to check for the errors with clk_get here. Also, I needed the > attached patch to keep asoc working on 24xx. Ok. Including your patch to the series. Forgot to change this to 24xx clocks. > > In general, how about create a custom clock for each mcbsp that handles > all the other clocks? That way you can have just one struct clk * for > each mcbsp and you can use standard clk_enable/disable calls instead > of the hard to read macros. > > You can add the custom clocks to clock fwk with clk_register() during > the omap specific mcbsp init depending on which mcbsp's are in use > from board-*.c files. Then the custom clock defines it's own > enable/disable function that just calls the clk_enable/disable on the > right mcbsp clocks. > > <snip> > These macros make things hard to read.. It would be best to have > things set up in a way so you can just call clk_enable/disable in > mcbsp.c. I thought to do it as you describe above but I made it different to avoid duplicated code into mach-omap1 and mach-omap2. However, as you said the code became too hard to understand, I believe it is better to make it simple. I'm going to send a new version of this series including: 1. your patch to 24xx 2. clock changes for mach-omap1 and mach-omap2 3. module release for mach-omap1 and mach-omap2 as recommended by Trilok > > Tony > > >> +int omap_mcbsp_init(void); >> +void omap_mcbsp_register_board_cfg(struct omap_mcbsp_platform_data *config, >> + int size); >> void omap_mcbsp_config(unsigned int id, const struct omap_mcbsp_reg_cfg * config); >> int omap_mcbsp_request(unsigned int id); >> void omap_mcbsp_free(unsigned int id); >> -- >> 1.5.5.1.67.gbdb8.dirty >> > -- Eduardo Bezerra Valentin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
