Re: [PATCH] Fix n800 build - Remove kernel config conditional declaration of TSC2005 device config structures

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, May 25, 2008 at 10:45:41AM +0200, trickie@xxxxxxxxx wrote:
> 
> Signed-off-by: Nick Loeve <trickie@xxxxxxxxx>
> ---
>  arch/arm/mach-omap2/board-n800.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/board-n800.c b/arch/arm/mach-omap2/board-n800.c
> index ae85c2c..f902482 100644
> --- a/arch/arm/mach-omap2/board-n800.c
> +++ b/arch/arm/mach-omap2/board-n800.c
> @@ -372,7 +372,6 @@ static struct omap2_mcspi_device_config cx3110x_mcspi_config = {
>  	.single_channel = 1,
>  };
>  
> -#ifdef CONFIG_TOUCHSCREEN_TSC2005
>  static struct tsc2005_platform_data tsc2005_config = {
>  	.reset_gpio = 94,
>  	.dav_gpio = 106
> @@ -382,7 +381,6 @@ static struct omap2_mcspi_device_config tsc2005_mcspi_config = {
>  	.turbo_mode	= 0,
>  	.single_channel = 1,
>  };
> -#endif

This one i think it should remain the way it is. I'm wondering if it'll
generate warnings in any way.

Could you try something?

Remove also the CONFIG_TOUCHSCREEN_TSC2301. And try building n800/n810,
n800-only and n810-only. Also flash and boot test them, please.

If you don't get any warnings and no errors. I'm ok with this patch when
you remove also the TSC2301 ifdef.

-- 
Best Regards,

Felipe Balbi
me@xxxxxxxxxxxxxxx
http://blog.felipebalbi.com
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux