On Fri, May 16, 2008 at 12:32 PM, arun c <arun.edarath@xxxxxxxxx> wrote: > Hi Koen, > >> diff --git a/drivers/video/omap/lcd_omap3beagle.c b/drivers/video/omap/lcd_omap3beagle.c >> new file mode 100644 >> index 0000000..f5b7466 >> --- /dev/null >> +++ b/drivers/video/omap/lcd_omap3beagle.c >> @@ -0,0 +1,135 @@ >> +/* >> + * LCD panel support for the TI OMAP3 Beagle board >> + * >> + * Author: Koen Kooi <koen@xxxxxxxxxxxxxxxx> >> + * >> + * Derived from drivers/video/omap/lcd-omap3evm.c >> + * >> + * This program is free software; you can redistribute it and/or modify it >> + * under the terms of the GNU General Public License as published by the >> + * Free Software Foundation; either version 2 of the License, or (at your >> + * option) any later version. >> + * >> + * This program is distributed in the hope that it will be useful, but >> + * WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU >> + * General Public License for more details. >> + * >> + * You should have received a copy of the GNU General Public License along >> + * with this program; if not, write to the Free Software Foundation, Inc., >> + * 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. >> + */ >> + >> +#include <linux/module.h> >> +#include <linux/platform_device.h> >> +#include <linux/i2c/twl4030.h> >> + >> +#include <asm/arch/gpio.h> >> +#include <asm/arch/mux.h> >> +#include <asm/arch/omapfb.h> >> +#include <asm/mach-types.h> >> + >> +#define LCD_PANEL_ENABLE_GPIO 170 >> + >> +#define LCD_XRES 1024 >> +#define LCD_YRES 768 > > I don't think there is a need for LCD_PIXCLOCK_MAX > and LCD_PIXCLOCK_MIN. It should be changed to > LCD_PIXCLOCK, am I right? Sorry a small change it should not be LCD_PIXCLOCK , only LCD_PIXCLOCK_MAX is enough. > >> +#define LCD_PIXCLOCK_MAX 64000 /* in kHz */ >> +#define LCD_PIXCLOCK_MIN 64000 /* in kHz */ > > Regards, > Arun C > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
