-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Op 30 apr 2008, om 16:14 heeft Steve Sakoman het volgende geschreven:
From: Steve Sakoman <steve@xxxxxxxxxxx>
Add LCD support for OMAP3 EVM
Signed-off-by: Steve Sakoman <steve@xxxxxxxxxxx>
---
+#define LCD_PIXCLOCK_MAX 41700 /* in pico seconds */
+#define LCD_PIXCLOCK_MIN 38000 /* in pico seconds */
I strongly suspect the above comments needs to be "/* in kHz */ ...
+struct lcd_panel omap3evm_panel = {
+ .name = "omap3evm",
+ .config = OMAP_LCDC_PANEL_TFT | OMAP_LCDC_INV_VSYNC |
+ OMAP_LCDC_INV_HSYNC,
+
+ .bpp = 16,
+ .data_lines = 18,
+ .x_res = LCD_XRES,
+ .y_res = LCD_YRES,
+ .hsw = 3, /* hsync_len (4) - 1 */
+ .hfp = 3, /* right_margin (4) - 1 */
+ .hbp = 39, /* left_margin (40) - 1 */
+ .vsw = 1, /* vsync_len (2) - 1 */
+ .vfp = 2, /* lower_margin */
+ .vbp = 7, /* upper_margin (8) - 1 */
+
+ .pixel_clock = LCD_PIXCLOCK_MAX,
... since pixel_clock seems to be in kHz. Could someone confirm this?
regards,
Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
iD8DBQFIJH1KMkyGM64RGpERAifEAJwLITHNkhjJ/zhKKiTFdVEq+6AuMgCfVoXd
oFX58FQibqqSyaIk4sTVCNE=
=yJ/0
-----END PGP SIGNATURE-----
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
