Re: [PATCH] Fix n800 build - only register HW keyboard on i2c board if CONFIG_MACH_NOKIA_N810

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Fri, May 2, 2008 at 3:17 PM, Felipe Balbi <me@xxxxxxxxxxxxxxx> wrote:
>
>
> On Fri,  2 May 2008 15:05:35 +0200, trickie@xxxxxxxxx wrote:
>> lm8323_pdata is only present if CONFIG_MACH_NOKIA_N810
>
> that's true but CONFIG_MACH_NOKIA_N810 is always true
> if you use n800_defconfig.

Yes true. I have been playing with a custom .config based on Tony's
experiments here: http://www.muru.com/linux/n8x0/ but for my n800
only.

Hence I noticed this if CONFIG_MACH_NOKIA_N810 is not defined.

>
> Anyways, good catch.
>
>> Signed-off-by: Nick Loeve <trickie@xxxxxxxxx>
>> ---
>>  arch/arm/mach-omap2/board-n800.c |    2 ++
>>  1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/board-n800.c
>> b/arch/arm/mach-omap2/board-n800.c
>> index 8b5956b..b62f2d5 100644
>> --- a/arch/arm/mach-omap2/board-n800.c
>> +++ b/arch/arm/mach-omap2/board-n800.c
>> @@ -654,12 +654,14 @@ static struct i2c_board_info __initdata
>> n800_i2c_board_info_2[] = {
>>               I2C_BOARD_INFO("tea5761", 0x10),
>>       },
>>  #endif
>> +#ifdef CONFIG_MACH_NOKIA_N810
>>       {
>>               I2C_BOARD_INFO("lm8323", 0x45),
>>               .type           = "lm8323",
>>               .irq            = OMAP_GPIO_IRQ(109),
>>               .platform_data  = &lm8323_pdata,
>>       },
>> +#endif
>>       {
>>               I2C_BOARD_INFO("tsl2563", 0x29),
>>               .type           = "tsl2563",
>> --
>> 1.5.5.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> Best Regards,
>
> Felipe Balbi
> http://felipebalbi.com
> me@xxxxxxxxxxxxxxx
>
>



-- 
Nick Loeve
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux