Sorry in advance for the newbie question. I noticed that arch/arm/configs/omap3_beagle_defconfig has nothing defined under "Device Drivers" between "Sound" and "CBUS support" where the "MMC/SD Card Drivers" should go. Is this intentional? Since Koen's patch enables MMC/SD functionality, does it not make sense to enable it in the defconfig such as below? diff --git a/arch/arm/configs/omap3_beagle_defconfig b/arch/arm/configs/omap3_beagle_defconfig index 9e4a4a5..7f57553 100644 --- a/arch/arm/configs/omap3_beagle_defconfig +++ b/arch/arm/configs/omap3_beagle_defconfig @@ -678,12 +678,28 @@ CONFIG_DUMMY_CONSOLE=y # CONFIG_SOUND is not set # CONFIG_HID_SUPPORT is not set # CONFIG_USB_SUPPORT is not set -# CONFIG_MMC is not set # CONFIG_NEW_LEDS is not set CONFIG_RTC_LIB=y # CONFIG_RTC_CLASS is not set # +# MMC/SD Card Drivers +# +CONFIG_MMC=y +CONFIG_MMC_BLOCK=y +CONFIG_MMC_BLOCK_BOUNCE=y +# CONFIG_SDIO_UART is not set + +# +# MMC/SD Host Controller Drivers +# +CONFIG_MMC_OMAP_HS=y +# CONFIG_NEW_LEDS is not set +CONFIG_RTC_LIB=y +# CONFIG_RTC_CLASS is not set +# CONFIG_UIO is not set + +# # CBUS support # # CONFIG_CBUS is not set > -----Original Message----- > From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap- > owner@xxxxxxxxxxxxxxx] On Behalf Of Koen Kooi > Sent: Wednesday, April 23, 2008 2:41 AM > To: linux-omap@xxxxxxxxxxxxxxx > Cc: Syed Mohammed, Khasim > Subject: Re: [PATCH 1/1] ARM: OMAP: omap3beagle: register SD > interface > > From dac3cdc5952ab39fa7ae0545d43e2daa95329b07 Mon Sep 17 00:00:00 > 2001 > From: Koen Kooi <koen@xxxxxxxxxxxxxxxx> > Date: Wed, 23 Apr 2008 09:38:31 +0200 > Subject: [PATCH] omap3beagle: register SD interface > > Signed-off-by: Koen Kooi <koen@xxxxxxxxxxxxxxxx> > --- > arch/arm/mach-omap2/Makefile | 3 ++- > arch/arm/mach-omap2/board-omap3beagle.c | 9 +++++++++ > include/asm-arm/arch-omap/board-omap3beagle.h | 2 ++ > 3 files changed, 13 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach- > omap2/Makefile > index 9414141..84d99d2 100644 > --- a/arch/arm/mach-omap2/Makefile > +++ b/arch/arm/mach-omap2/Makefile > @@ -35,7 +35,8 @@ obj-$(CONFIG_MACH_OMAP_3430SDP) += board- > 3430sdp.o \ > board-3430sdp-usb.o \ > board-3430sdp-flash.o > obj-$(CONFIG_MACH_OMAP3EVM) += board-omap3evm.o > -obj-$(CONFIG_MACH_OMAP3_BEAGLE) += board-omap3beagle.o > +obj-$(CONFIG_MACH_OMAP3_BEAGLE) += board-omap3beagle.o \ > + board-sdp-hsmmc.o > obj-$(CONFIG_MACH_OMAP_APOLLON) += board-apollon.o \ > board-apollon-mmc.o \ > board-apollon-keys.o > diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach- > omap2/board-omap3beagle.c > index 0727ee2..c03bb26 100644 > --- a/arch/arm/mach-omap2/board-omap3beagle.c > +++ b/arch/arm/mach-omap2/board-omap3beagle.c > @@ -48,8 +48,16 @@ static void __init omap3_beagle_init_irq(void) > omap_gpio_init(); > } > > +static struct omap_mmc_config omap3beagle_mmc_config __initdata = { > + .mmc [0] = { > + .enabled = 1, > + .wire4 = 1, > + }, > +}; > + > static struct omap_board_config_kernel omap3_beagle_config[] > __initdata = { > { OMAP_TAG_UART, &omap3_beagle_uart_config }, > + { OMAP_TAG_MMC, &omap3beagle_mmc_config }, > }; > > static void __init omap3_beagle_init(void) > @@ -57,6 +65,7 @@ static void __init omap3_beagle_init(void) > omap_board_config = omap3_beagle_config; > omap_board_config_size = ARRAY_SIZE(omap3_beagle_config); > omap_serial_init(); > + sdp_mmc_init(); > } > > arch_initcall(omap3_beagle_i2c_init); > diff --git a/include/asm-arm/arch-omap/board-omap3beagle.h b/include/ > asm-arm/arch-omap/board-omap3beagle.h > index c42db78..fcdf0bc 100644 > --- a/include/asm-arm/arch-omap/board-omap3beagle.h > +++ b/include/asm-arm/arch-omap/board-omap3beagle.h > @@ -29,6 +29,8 @@ > #ifndef __ASM_ARCH_OMAP3_BEAGLE_H > #define __ASM_ARCH_OMAP3_BEAGLE_H > > +extern void sdp_mmc_init(void); > + > #ifdef CONFIG_TWL4030_CORE > > #define TWL4030_IRQNUM INT_34XX_SYS_NIRQ > -- > 1.5.4.3 > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" > in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
