On Tue, Apr 22, 2008 at 07:00:04PM +0200, Koen Kooi wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
>
> Op 22 apr 2008, om 18:57 heeft David Brownell het volgende geschreven:
>> On Tuesday 22 April 2008, Koen Kooi wrote:
>>> --- a/include/asm-arm/arch-omap/board-omap3beagle.h
>>> +++ b/include/asm-arm/arch-omap/board-omap3beagle.h
>>> @@ -29,6 +29,8 @@
>>> #ifndef __ASM_ARCH_OMAP3_BEAGLE_H
>>> #define __ASM_ARCH_OMAP3_BEAGLE_H
>>>
>>> +extern void __init sdp_mmc_init(void);
>>> +
>>> #ifdef CONFIG_TWL4030_CORE
>>>
>>> #define TWL4030_IRQNUM INT_34XX_SYS_NIRQ
>>
>> That's really not the right place to declare shared
>> routines. Plus of course, since that routine isn't
>> specific to SDP boards it shouldn't use that name...
Besides this, it'll break compilation cuz of __init. That one is defined
in <linux/init.h> and it's not being included here. In any case, the
best would be to be __{init,exit,devinit,devexit} from prototypes.
--
Best Regards,
Felipe Balbi
me@xxxxxxxxxxxxxxx
http://blog.felipebalbi.com
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
