RE: [PATCH 1/4] Updating Kconfig and Makefile for OMAP3 EVM support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> >> > Index: my_branch/arch/arm/mach-omap2/Kconfig
> >> > ===================================================================
> >> > --- my_branch.orig/arch/arm/mach-omap2/Kconfig	2008-04-14
> >> 16:07:11.000000000 +0530
> >> > +++ my_branch/arch/arm/mach-omap2/Kconfig	2008-04-14
> >> 16:07:41.000000000 +0530
> >> > @@ -98,10 +98,14 @@
> >> >  	bool "OMAP 2430 SDP board"
> >> >  	depends on ARCH_OMAP2 && ARCH_OMAP2430
> >> >
> >> > +config MACH_OMAP_2430OSK
> >> > +	bool "OMAP 2430 OSK board"
> >> > +	depends on ARCH_OMAP2 && ARCH_OMAP24XX
> >> > +
> >> >  config MACH_OMAP_3430SDP
> >> >  	bool "OMAP 3430 SDP board"
> >> >  	depends on ARCH_OMAP3 && ARCH_OMAP34XX
> >> >
> >> > -config MACH_OMAP_2430OSK
> >> > -	bool "OMAP 2430 OSK board"
> >> > -	depends on ARCH_OMAP2 && ARCH_OMAP24XX
> >> > +config MACH_OMAP3EVM
> >> > +	bool "OMAP 3530 EVM board"
> >> > +	depends on ARCH_OMAP3 && ARCH_OMAP34XX
> >>
> >> Do you really need to move 2430OSK here?
> >> It looks like unnecessary change.
> >>
> >> please revert.
> >>
> > This change is good as it lists all omap2 followed by omap3 boards.
> > Otherwise it mixes OMAP2 boards with OMAP3 boards.
> 
> so put it in a separate patch. It has nothing to do with
> "Adding support for OMAP3 EVM"

Why? ???

These lines add OMAP3 EVM

+config MACH_OMAP3EVM
+	bool "OMAP 3530 EVM board"
+	depends on ARCH_OMAP3 && ARCH_OMAP34XX

The other lines are re-arranging OMAP2 and OMAP3 boards. 

We can make two separate patches but this fix seems to be simple.

Regards,
Khasim
��.n��������+%������w��{.n�����{�������ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux