RE: [PATCH 1/4] Updating Kconfig and Makefile for OMAP3 EVM support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Felipe Balbi [mailto:me@xxxxxxxxxxxxxxx]
> Sent: Monday, April 14, 2008 11:35 PM
> To: Syed Mohammed, Khasim
> Cc: linux-omap@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 1/4] Updating Kconfig and Makefile for OMAP3 EVM
> support
> 
> On Mon, Apr 14, 2008 at 05:36:50PM +0530, Syed Mohammed, Khasim wrote:
> >
> > Updated Kconfig and Makefile for OMAP3 EVM support
> >
> > Signed-off-by: Syed Mohammed Khasim <khasim@xxxxxx>
> > ---
> >  arch/arm/mach-omap2/Kconfig  |   10 +++++++---
> >  arch/arm/mach-omap2/Makefile |    1 +
> >  2 files changed, 8 insertions(+), 3 deletions(-)
> >
> > Index: my_branch/arch/arm/mach-omap2/Kconfig
> > ===================================================================
> > --- my_branch.orig/arch/arm/mach-omap2/Kconfig	2008-04-14
> 16:07:11.000000000 +0530
> > +++ my_branch/arch/arm/mach-omap2/Kconfig	2008-04-14
> 16:07:41.000000000 +0530
> > @@ -98,10 +98,14 @@
> >  	bool "OMAP 2430 SDP board"
> >  	depends on ARCH_OMAP2 && ARCH_OMAP2430
> >
> > +config MACH_OMAP_2430OSK
> > +	bool "OMAP 2430 OSK board"
> > +	depends on ARCH_OMAP2 && ARCH_OMAP24XX
> > +
> >  config MACH_OMAP_3430SDP
> >  	bool "OMAP 3430 SDP board"
> >  	depends on ARCH_OMAP3 && ARCH_OMAP34XX
> >
> > -config MACH_OMAP_2430OSK
> > -	bool "OMAP 2430 OSK board"
> > -	depends on ARCH_OMAP2 && ARCH_OMAP24XX
> > +config MACH_OMAP3EVM
> > +	bool "OMAP 3530 EVM board"
> > +	depends on ARCH_OMAP3 && ARCH_OMAP34XX
> 
> Do you really need to move 2430OSK here?
> It looks like unnecessary change.
> 
> please revert.
> 
This change is good as it lists all omap2 followed by omap3 boards. Otherwise it mixes OMAP2 boards with OMAP3 boards.

Regards,
Khasim
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux