> -----Original Message----- > From: Felipe Balbi [mailto:me@xxxxxxxxxxxxxxx] > Sent: Monday, April 14, 2008 11:42 PM > To: Syed Mohammed, Khasim > Cc: linux-omap@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 2/2] New Board file for OMAP3 EVM > > On Mon, Apr 14, 2008 at 05:40:48PM +0530, Syed Mohammed, Khasim wrote: > > > > New board file for OMAP3 EVM > > > > Signed-off-by: Syed Mohammed Khasim <khasim@xxxxxx> > > --- > > arch/arm/mach-omap2/board-omap3-evm.c | 79 > ++++++++++++++++++++++++++++++++++ > > 1 file changed, 79 insertions(+) > > > > Index: my_branch/arch/arm/mach-omap2/board-omap3-evm.c > > =================================================================== > > --- /dev/null 1970-01-01 00:00:00.000000000 +0000 > > +++ my_branch/arch/arm/mach-omap2/board-omap3-evm.c 2008-04-14 > 16:18:41.000000000 +0530 > > @@ -0,0 +1,79 @@ > > +/* > > + * linux/arch/arm/mach-omap2/board-omap3-evm.c > > + * > > + * Copyright (C) 2008 Texas Instruments > > + * > > + * Modified from mach-omap2/board-3430sdp.c > > + * > > + * Initial code: Syed Mohammed Khasim > > + * > > + * This program is free software; you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License version 2 as > > + * published by the Free Software Foundation. > > + */ <snip> > > +static struct omap_board_config_kernel omap3_evm_config[] __initdata = > { > > + {OMAP_TAG_UART, &omap3_evm_uart_config }, > > +}; > > + > > +static void __init omap3_evm_init(void) > > +{ > > + omap_board_config = omap3_evm_config; > > + omap_board_config_size = ARRAY_SIZE(omap3_evm_config); > > + omap_serial_init(); > > +} > > + > > +arch_initcall(omap3_evm_i2c_init); > > why not putting the omap3_evm_i2c_init() call below > omap_serial_init() inside omap3_evm_init()?? > I2C init needs clock init to be completed, I think this is good enough as it is in sync with other omap boards. Many thanks for reviewing the code. Regards, khasim -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
