On Mon, Apr 14, 2008 at 2:16 PM, Felipe Balbi <me@xxxxxxxxxxxxxxx> wrote: > On Mon, Apr 14, 2008 at 11:53:00AM -0400, Eduardo Valentin wrote: > > From: Eduardo Valentin <eduardo.valentin@xxxxxxxxxxx> > > > > This patch fix lots of warnings and errors reported by > > scripts/checkpatch.pl on arch/arm/plat-omap/mcbsp.c. > > > > Signed-off-by: Eduardo Valentin <eduardo.valentin@xxxxxxxxxxx> > > Hi, if you're touching mcbsp.c could you please also take a look at > this: > > $ scripts/checkpatch.pl --strict --file arch/arm/plat-omap/mcbsp.c > CHECK: spinlock_t definition without comment > #60: FILE: arm/plat-omap/mcbsp.c:60: > + spinlock_t lock; > > total: 0 errors, 0 warnings, 1 checks, 799 lines checked > > arch/arm/plat-omap/mcbsp.c has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > maybe you could just add this comment and resend this same patch ? > For sure. And here is another updated version of the previous patch with the comment. > -- > Best Regards, > > Felipe Balbi > me@xxxxxxxxxxxxxxx > http://blog.felipebalbi.com > -- Eduardo Bezerra Valentin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
