Re: [PATCH 1/2] PLAT-OMAP: McBSP: Coding style cleanup on arch/arm/plat-omap/mcbsp.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 14, 2008 at 11:53:00AM -0400, Eduardo Valentin wrote:
> From: Eduardo Valentin <eduardo.valentin@xxxxxxxxxxx>
> 
> This patch fix lots of warnings and errors reported by
> scripts/checkpatch.pl on arch/arm/plat-omap/mcbsp.c.
> 
> Signed-off-by: Eduardo Valentin <eduardo.valentin@xxxxxxxxxxx>

Hi, if you're touching mcbsp.c could you please also take a look at
this:

$ scripts/checkpatch.pl --strict --file arch/arm/plat-omap/mcbsp.c
CHECK: spinlock_t definition without comment
#60: FILE: arm/plat-omap/mcbsp.c:60:
+       spinlock_t                   lock;

total: 0 errors, 0 warnings, 1 checks, 799 lines checked

arch/arm/plat-omap/mcbsp.c has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

maybe you could just add this comment and resend this same patch ?

-- 
Best Regards,

Felipe Balbi
me@xxxxxxxxxxxxxxx
http://blog.felipebalbi.com
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux