Re: [PATCH 00/23] General checkpatch.pl cleanup for twl and musb drivers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 11, 2008 at 02:36:05PM +0530, ext Gadiyar, Anand wrote:
> Nice job! :)
> 
> By the way, how did you manage to get a list of checkpatch ERRORS and WARNINGS on a set of files?
> Did you do a compare with /dev/null or is there a better way?

scripts/checkpatch.pl --file drivers/usb/musb/*.[ch] ;-)

> 
> Regards,
> Anand
> 
> > -----Original Message-----
> > From: linux-omap-owner@xxxxxxxxxxxxxxx 
> > [mailto:linux-omap-owner@xxxxxxxxxxxxxxx] On Behalf Of Felipe Balbi
> > Sent: Friday, April 11, 2008 1:58 PM
> > To: linux-omap@xxxxxxxxxxxxxxx
> > Cc: Felipe Balbi
> > Subject: [PATCH 00/23] General checkpatch.pl cleanup for twl 
> > and musb drivers
> > 
> > The following series gets rid of checkpatch.pl ERRORS and WARNINGS
> > for both twl4030 and musb drivers. I left some WARNINGS in musb_core.c
> > because fixing them would decrease the code readability. Line 
> > was only one
> > character over the 80 max so it didn't make sense to fix that.
> > 
> > Felipe Balbi (23):
> >   I2C: TWL4030: checkpatch.pl fixes for twl4030-core.c
> >   I2C: TWL4030: checkpatch.pl fixes for twl4030-usb.c
> >   I2C: TWL4030: checkpatch.pl fixes for twl4030-gpio.c
> >   I2C: TWL4030: checkpatch.pl fixes to tlw4030.h
> >   I2C: TLW4030: checkpatch.pl fixes to tlw4030-rtc.h
> >   I2C: TWL4030: checkpatch.pl fixes to rtc-twl4030.c
> >   USB: MUSB: checkpatch.pl fixes to cppi_dma.c
> >   USB: MUSB: checkpatch.pl fixes to davinci.c
> >   USB: MUSB: checkpatch.pl fixed to musb_core.c
> >   USB: MUSB: checkpatch.pl fixes to musb_gadget.c
> >   USB: MUSB: checkpatch.pl fixed to musb_gadget_ep0.c
> >   USB: MUSB: checkpatch.pl fixed to musb_host.c
> >   USB: MUSB: checkpatch.pl fixed to musb_procfs.c
> >   USB: MUSB: checkpatch.pl fixes to musb_virthub.c
> >   USB: MUSB: checkpatch.pl fixes to musbhsdma.c
> >   USB: MUSB: checkpatch.pl fixes to omap2430.c
> >   USB: MUSB: checkpatch.pl fixes to tusb6010.c
> >   USB: MUSB: checkpatch.pl fixes to tusb6010_omap.c
> >   USB: MUSB: checkpatch.pl fixes to davinci.h
> >   USB: MUSB: checkpatch.pl fixes to musb_core.h
> >   USB: MUSB: checkpatch.pl fixes to musb_io.h
> >   USB: MUSB: checkpatch.pl fixed to musb_regs.h
> >   USB: MUSB: checkpatch.pl fixes to musb_debug.h
> > 
> >  drivers/i2c/chips/twl4030-core.c   |   61 
> > +++++++++++++---------------
> >  drivers/i2c/chips/twl4030-gpio.c   |   37 ++++++++---------
> >  drivers/i2c/chips/twl4030-usb.c    |    3 +-
> >  drivers/rtc/rtc-twl4030.c          |   77 
> > ++++++++++++++++++-----------------
> >  drivers/usb/musb/cppi_dma.c        |    2 +-
> >  drivers/usb/musb/davinci.c         |    8 ++--
> >  drivers/usb/musb/davinci.h         |    4 +-
> >  drivers/usb/musb/musb_core.c       |   35 +++++++---------
> >  drivers/usb/musb/musb_core.h       |   10 ++--
> >  drivers/usb/musb/musb_debug.h      |   14 +++---
> >  drivers/usb/musb/musb_gadget.c     |   13 +++---
> >  drivers/usb/musb/musb_gadget_ep0.c |    2 +-
> >  drivers/usb/musb/musb_host.c       |   26 ++++++------
> >  drivers/usb/musb/musb_io.h         |    2 +-
> >  drivers/usb/musb/musb_procfs.c     |    8 ++--
> >  drivers/usb/musb/musb_regs.h       |   22 +++++-----
> >  drivers/usb/musb/musb_virthub.c    |    4 +-
> >  drivers/usb/musb/musbhsdma.c       |   17 ++++----
> >  drivers/usb/musb/omap2430.c        |    2 +-
> >  drivers/usb/musb/tusb6010.c        |   12 +++---
> >  drivers/usb/musb/tusb6010_omap.c   |   13 +++---
> >  include/linux/i2c/twl4030-rtc.h    |    4 +-
> >  include/linux/i2c/twl4030.h        |    6 +-
> >  23 files changed, 186 insertions(+), 196 deletions(-)
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe 
> > linux-omap" in
> > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > 

-- 
	- Balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux