On Fri, Apr 11, 2008 at 02:23:05PM +0530, ext Gadiyar, Anand wrote:
> > static int __init twl4030_init(void)
> > {
> > - int res;
> > -
> > - if ((res = i2c_add_driver(&twl4030_driver))) {
> > - printk(KERN_ERR "TWL4030: Driver registration failed\n");
> > - return res;
> > - }
> > -
> > - pr_info(KERN_INFO "TWL4030: Driver registration complete.\n");
> > -
> > - return 0;
> > + return i2c_add_driver(&twl4030_driver);
> > }
>
> You're losing the failure print here. Not sure if it matters, but I'm pointing it out anyway.
i2c subsystem will print it out for usb. No need to leave it here :)
if you follow i2c_add_driver, you'll get to
drivers/i2c/i2c-core.c:i2c_register_driver()
int i2c_register_driver(struct module *owner, struct i2c_driver *driver)
{
[...]
mutex_lock(&core_lock);
pr_debug("i2c-core: driver [%s] registered\n", driver->driver.name);
[...]
return 0;
}
--
- Balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
