Re: [PATCH 1/5] I2C: LM8323: Introduce lm8323 keypad driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 10, 2008 at 01:58:51AM +0200, ext andrzej zaborowski wrote:
> On 09/04/2008, Lauri Leukkunen <lauri.leukkunen@xxxxxxxxx> wrote:
> > In my opinion kernel should provide "correct" data to user-space, not
> >  some pseudo-random interference from the LCD.
> 
> I think this is discutible.  There's a number of userspace libraries
> written to talk tightly to the kernel and make that data more
> "correct", one of them is tslib.  Distros that come with tslib often
> have a set of device-specific config files for tslib which load tslib
> plugins for things like averaging, smoothing, checking bounds on the
> values.
> 
> One of the arguments for doing that in userspace is that of avoiding
> every touchscreen driver redoing the same averaging and/or limit
> checking code.  I agree thought that it may be better to sacrifice
> that for performance.

If everyone's doing the same thing, move it to drivers/input/, not to
userspace.  Why should we be forced to have _two_ drivers and
essentially maintain a stable kernel/userspace ABI between them? Surely
it's better to only have _one_ hardware-specific driver, rather than
half in the kernel, and half hidden behind an abstraction layer that is
meant to let you just deal with input events without knowing stupid
details about the hardware?

I don't see any coherent argument for it being in tslib.

Cheers,
Daniel

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux