Re: [PATCH 1/5] I2C: LM8323: Introduce lm8323 keypad driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/04/08 21:05 +0300, ext Felipe Balbi wrote:
> On Wed, Apr 09, 2008 at 07:26:31PM +0200, andrzej zaborowski wrote:
> > Question not really related to this patchset, but in the TSC2005
> > driver some averaging and limit checks are done to the ADC values.
> > Shouldn't that be done in userspace instead?  (The ADS784x and TSC2301
> > drivers do the same evidently.)
> 
> Now that's not really up to me, but if we move it now it probably won't
> provide the feature n810 needs. I mean, n810 is designed on top of the
> features provided by driver, the application probably expects the driver
> to do the averaging and limit checks so at least for tsc2005 I think
> it's not a good idea to change due to application requirements.

User-space is too late for this filtering, we would end up feeding ~1k samples
per second there, and that would simply clog the system pretty badly, can't
do much buffering either as that degrades interactive responsiveness of the
UI. In my opinion kernel should provide "correct" data to user-space, not
some pseudo-random interference from the LCD. Micro-kernel people will of
course disagree.

/lauri

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux