Hi Balbi,
On Wed, Mar 26, 2008 at 1:39 PM, Felipe Balbi <me@xxxxxxxxxxxxxxx> wrote:
> On Wed, Mar 26, 2008 at 11:33:45AM -0400, Eduardo Valentin wrote:
> > From: Felipe Balbi <felipe.balbi@xxxxxxxxx>
> >
> > Misc clean up in omap_hsmmc.c to beautify debugging output.
> >
> > Signed-off-by: Felipe Balbi <felipe.balbi@xxxxxxxxx>
>
> Here you should put what you changed just to ease the comparisson :-)
That's true. But the change was just to remove part of your patch that modified
something that was already removed. And it still keeps adding missing
line breaks :-).
> But ok... thanks for checking it :-)
>
>
>
> > Signed-off-by: Eduardo Valentin <eduardo.valentin@xxxxxxxxxxx>
> > ---
> > drivers/mmc/host/omap_hsmmc.c | 14 +++++++-------
> > 1 files changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
> > index 3d4a7d1..70f6895 100644
> > --- a/drivers/mmc/host/omap_hsmmc.c
> > +++ b/drivers/mmc/host/omap_hsmmc.c
> > @@ -146,7 +146,7 @@ static void omap_mmc_stop_clock(struct mmc_omap_host *host)
> > OMAP_HSMMC_WRITE(host->base, SYSCTL,
> > OMAP_HSMMC_READ(host->base, SYSCTL) & ~CEN);
> > if ((OMAP_HSMMC_READ(host->base, SYSCTL) & CEN) != 0x0)
> > - dev_dbg(mmc_dev(host->mmc), "MMC Clock is not stoped");
> > + dev_dbg(mmc_dev(host->mmc), "MMC Clock is not stoped\n");
> > }
> >
> > /*
> > @@ -401,7 +401,7 @@ static int omap_mmc_switch_opcond(struct mmc_omap_host *host, int vdd)
> >
> > return 0;
> > err:
> > - dev_dbg(mmc_dev(host->mmc), "Unable to switch operating voltage \n");
> > + dev_dbg(mmc_dev(host->mmc), "Unable to switch operating voltage\n");
> > return ret;
> > }
> >
> > @@ -760,11 +760,11 @@ static int __init omap_mmc_probe(struct platform_device *pdev)
> > * MMC can still work without debounce clock.
> > */
> > if (IS_ERR(host->dbclk))
> > - dev_dbg(mmc_dev(host->mmc), "Failed to get debounce clock \n");
> > + dev_dbg(mmc_dev(host->mmc), "Failed to get debounce clock\n");
> > else
> > if (clk_enable(host->dbclk) != 0)
> > dev_dbg(mmc_dev(host->mmc), "Enabling debounce"
> > - "clk failed\n");
> > + " clk failed\n");
> > else
> > host->dbclk_enabled = 1;
> >
> > @@ -793,7 +793,7 @@ static int __init omap_mmc_probe(struct platform_device *pdev)
> > ret = request_irq(host->irq, mmc_omap_irq, IRQF_DISABLED, pdev->name,
> > host);
> > if (ret) {
> > - dev_dbg(mmc_dev(host->mmc), "Unable to grab HSMMC IRQ");
> > + dev_dbg(mmc_dev(host->mmc), "Unable to grab HSMMC IRQ\n");
> > goto irq_err;
> > }
> >
> > @@ -820,7 +820,7 @@ err:
> > return ret;
> >
> > irq_err:
> > - dev_dbg(mmc_dev(host->mmc), "Unable to configure MMC IRQs");
> > + dev_dbg(mmc_dev(host->mmc), "Unable to configure MMC IRQs\n");
> > clk_disable(host->fclk);
> > clk_disable(host->iclk);
> > clk_put(host->fclk);
> > @@ -881,7 +881,7 @@ static int omap_mmc_suspend(struct platform_device *pdev, pm_message_t state)
> > if (ret)
> > dev_dbg(mmc_dev(host->mmc),
> > "Unable to handle MMC board"
> > - "level suspend\n");
> > + " level suspend\n");
> >
> > if (!(OMAP_HSMMC_READ(host->base, HCTL) & SDVSDET)) {
> > OMAP_HSMMC_WRITE(host->base, HCTL,
> > --
> > 1.5.4.2
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> --
> Best Regards,
>
> Felipe Balbi
> me@xxxxxxxxxxxxxxx
> http://blog.felipebalbi.com
>
--
Eduardo Bezerra Valentin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
