* David Cohen <dacohen@xxxxxxxxx> [080206 14:38]: > On Feb 6, 2008 5:18 PM, andrzej zaborowski <balrogg@xxxxxxxxx> wrote: > > Hi, > > > > On 06/02/2008, David Cohen <dacohen@xxxxxxxxx> wrote: > > > On Feb 6, 2008 3:46 PM, andrzej zaborowski <balrogg@xxxxxxxxx> wrote: > > > > Value and register offset got swapped in a dispc write. I noticed no > > > > malfunction connected with this, only a strange write to *_REVISION > > > > (offset zero). > > > > > > Here: > > > - "LCD panel %s enabled by bootloader (status 0x%04x)\n", > > > + "LCD panel %senabled by bootloader (status 0x%04x)\n", > > > I think you didn't mean to modify this line also. > > > > I did, but since it's a formattng fix, I didn't think there was much > > point in explaining what it does. Feel free to drop it. > > Adding "Formatting fix" would be enough. But split it into 2 patches > seems to be the better choice, as these 2 changes are related to > different things. > > > > > > > > > BTW, try to send inline attached patch. It's better to read it. > > > > Okays. I would normally send both attached and inlined if it was a > > bigger change (my mailer won't easily preserve tabs in inlined code). > > The easier way to send inline patches preserving tabs is using git. > You can read about git-format-patch and git-send-email. Yeah good comments for next patches :) Pushing this patch today. Tony - To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
