Re: [PATCH] OMAP: LCD: parameter order typo

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 06/02/2008, David Cohen <dacohen@xxxxxxxxx> wrote:
> On Feb 6, 2008 3:46 PM, andrzej zaborowski <balrogg@xxxxxxxxx> wrote:
> > Value and register offset got swapped in a dispc write. I noticed no
> > malfunction connected with this, only a strange write to *_REVISION
> > (offset zero).
>
> Here:
> -               "LCD panel %s enabled by bootloader (status 0x%04x)\n",
> +               "LCD panel %senabled by bootloader (status 0x%04x)\n",
> I think you didn't mean to modify this line also.

I did, but since it's a formattng fix, I didn't think there was much
point in explaining what it does. Feel free to drop it.

>
> BTW, try to send inline attached patch. It's better to read it.

Okays. I would normally send both attached and inlined if it was a
bigger change (my mailer won't easily preserve tabs in inlined code).

Regards
-
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux